cl loadTypedef: fix TypeIgnore; cmd/llcppg: support subPkgs - #879
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
==========================================
+ Coverage 87.32% 88.36% +1.04%
==========================================
Files 22 22
Lines 1878 1857 -21
==========================================
+ Hits 1640 1641 +1
+ Misses 238 216 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Review summary
This PR moves Gen from tool/gen.go into cmd/llcppg/gen.go and adds sub-package generation (Pkgs + Apply + genPkg/convPkg), refines the block-pointer log message, switches typedef ignore matching to the trimmed local name, and fixes config comments.
The core refactor is sound: the expensive clang.Index is correctly shared across sub-packages, gogen.GeneratedHeader is restored via defer, and trimTypeTag now normalizes tagged C names consistently with the rest of cl. No performance concerns.
The findings below are about robustness and consistency in the new sub-package path plus a comment accuracy nit. None are blocking.
Additional findings
tool/config.go:69: [P3] Document (and consider validating) Apply's selective field inheritance:Applyinherits onlyLanguage,Stdlib,LLGoPackage,CFlags, andDepsfrom the parent;TypeIgnore,Rename, the*Prefixfields,TypeAbbr,Class/NonClass,NSIgnore, andDir/Filesare not. If this selective inheritance is intentional, a doc comment onApplylisting which fields are inherited (and why the rest are excluded) would prevent future "bug or feature?" confusion.
No description provided.