Skip to content

github.com/goplus/llcppg => github.com/xgo-dev/llcppg - #691

Closed
xushiwei wants to merge 5 commits into
goplus:mainfrom
xushiwei:q
Closed

xushiwei wants to merge 5 commits into
goplus:mainfrom
xushiwei:q

Conversation

@xushiwei

@xushiwei xushiwei commented Sep 6, 2026

Copy link
Copy Markdown
Member

No description provided.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: module rename goplus/llcppg → xgo-dev/llcppg

The rename is thorough and internally consistent: grep finds zero remaining goplus/llcppg self-references, all nested testdata go.mod paths, the codecov slug, README badges, and the #530 doc link were updated together. External goplus/* dependencies (gogen, lib, llgo, llpkgstore) and the XGo badge (goplus/xgo) were correctly left untouched. Import regrouping in the libxslt testdata matches goimports conventions.

One build-breaking issue in the _cmptest module is flagged inline. A few operational follow-ups are below.

Operational follow-ups (not blocking the diff):

  • Codecov token — .github/workflows/go.yml now uses slug: xgo-dev/llcppg but still uploads with secrets.CODECOV_TOKEN. Codecov tokens are repo/owner-scoped; confirm a fresh CODECOV_TOKEN is provisioned for xgo-dev/llcppg, otherwise coverage upload will fail (or associate to the wrong project).
  • Old-namespace supply chain — after the rename, github.com/goplus/llcppg becomes re-registerable. Downstream consumers importing the old path could be redirected to an attacker-controlled repo if it is ever transferred/re-created. Recommend retaining/archiving the old repo.
  • README badges — Go Report Card / Language / DeepWiki badges were removed. Reasonable during a rename (those services index the old slug), but please confirm the removal is intentional.

Comment thread _cmptest/go.mod Outdated
Comment thread _cmptest/go.sum Outdated
@xushiwei xushiwei closed this Sep 6, 2026
@xushiwei
xushiwei deleted the q branch September 6, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant