Conversation
Contributor
There was a problem hiding this comment.
Review: module rename goplus/llcppg → xgo-dev/llcppg
The rename is thorough and internally consistent: grep finds zero remaining goplus/llcppg self-references, all nested testdata go.mod paths, the codecov slug, README badges, and the #530 doc link were updated together. External goplus/* dependencies (gogen, lib, llgo, llpkgstore) and the XGo badge (goplus/xgo) were correctly left untouched. Import regrouping in the libxslt testdata matches goimports conventions.
One build-breaking issue in the _cmptest module is flagged inline. A few operational follow-ups are below.
Operational follow-ups (not blocking the diff):
- Codecov token —
.github/workflows/go.ymlnow usesslug: xgo-dev/llcppgbut still uploads withsecrets.CODECOV_TOKEN. Codecov tokens are repo/owner-scoped; confirm a freshCODECOV_TOKENis provisioned forxgo-dev/llcppg, otherwise coverage upload will fail (or associate to the wrong project). - Old-namespace supply chain — after the rename,
github.com/goplus/llcppgbecomes re-registerable. Downstream consumers importing the old path could be redirected to an attacker-controlled repo if it is ever transferred/re-created. Recommend retaining/archiving the old repo. - README badges — Go Report Card / Language / DeepWiki badges were removed. Reasonable during a rename (those services index the old slug), but please confirm the removal is intentional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.