deps: bump reflectx to v1.8.2 - #511
Merged
Merged
Conversation
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review: bump reflectx v1.8.1 → v1.8.2
This PR bumps github.com/goplus/reflectx from v1.8.1 to v1.8.2 and aligns the iface_patch CLI install version in CI. Clean, self-contained dependency bump — no issues found.
Verified:
go.mod,go.sum, and.github/workflows/go.ymlall agree on v1.8.2; no stale v1.8.1/v1.8.0 references remain in the repo.go.sumcontains both the module (h1:) and/go.modhashes for v1.8.2, matching the official checksum database — supply-chain integrity intact.- The
iface_patch@v1.8.2install version matches the reflectx library version, which is important since the runtime iface-patch tool must stay in sync with the library used to build ixgo. - No application code, docs, or examples reference the version, so nothing else needed updating (README uses
@latest, a pre-existing intentional choice).
Pin iface_patch in CI to the same version. Add an interp test for unnamed structs with a promoted method and an unexported field (NewMethodSet clone; empty PkgPath on reflectx before v1.8.2).
visualfc
force-pushed
the
deps-reflectx-v1.8.2
branch
from
September 18, 2026 11:40
c7d44c9 to
6679688
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/goplus/reflectxto v1.8.2.go install github.com/goplus/reflectx/cmd/iface_patch@v1.8.2.TestUnnamedStructUnexportedFieldPkgPath: unnamed struct with an embedded method and an unexported field (ixgoNewMethodSetclone). Fails on reflectx v1.8.0 (PkgPathempty), passes on v1.8.2.reflectx v1.8.1 → v1.8.2 includes:
PkgPath.PkgPathcopy on llgonewType/SetUnderlying, and gcSetUnderlying.SetUnderlyingfor interfaces re-encodesnameOff/typeOff.Named-type and unnamed-interface interp cases still pass on v1.8.0 (PkgPath already set by
NamedTypeOf/InterfaceOf) and are not included.Test plan
go test -run TestUnnamedStructUnexportedFieldPkgPath .(fail v1.8.0, pass v1.8.2)