fix: preserve slider and list monitor configuration - #3523
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Review: Monitor slider/list config
This PR cleanly adds slider (mode 3) and list (mode 4) configuration fields (sliderMin, sliderMax, isDiscrete, width, height) to the Monitor widget model. The implementation is well-structured:
- New fields are kept in sync across
MonitorInits,RawMonitorConfig, the class, the constructor,clone(), andexport(). load()correctly lets the new fields flow through...initsinto the constructor (verified by the round-trip tests).- Test coverage is strong: defaulting, mode-conditional export presence/absence, and full
load → export → JSON round-trip → loadcycles.
No blocking issues. A few points below are worth a deliberate decision. No performance concerns; the new fields carry no security-critical impact (client-side display config only).
nighca
approved these changes
Sep 21, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.