Skip to content

fix: preserve slider and list monitor configuration - #3523

Merged
nighca merged 3 commits into
goplus:devfrom
go-wyvern:fix/monitor-slider-list-config
Sep 21, 2026
Merged

nighca merged 3 commits into
goplus:devfrom
go-wyvern:fix/monitor-slider-list-config

Conversation

@go-wyvern

Copy link
Copy Markdown
Member

No description provided.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Monitor slider/list config

This PR cleanly adds slider (mode 3) and list (mode 4) configuration fields (sliderMin, sliderMax, isDiscrete, width, height) to the Monitor widget model. The implementation is well-structured:

  • New fields are kept in sync across MonitorInits, RawMonitorConfig, the class, the constructor, clone(), and export().
  • load() correctly lets the new fields flow through ...inits into the constructor (verified by the round-trip tests).
  • Test coverage is strong: defaulting, mode-conditional export presence/absence, and full load → export → JSON round-trip → load cycles.

No blocking issues. A few points below are worth a deliberate decision. No performance concerns; the new fields carry no security-critical impact (client-side display config only).

Comment thread spx-gui/src/models/spx/widget/monitor.ts
Comment thread spx-gui/src/models/spx/widget/monitor.ts
Comment thread spx-gui/src/models/spx/widget/monitor.ts
@nighca
nighca merged commit a688891 into goplus:dev Sep 21, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
Preview – builder 5d0ce74e Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants