Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

chore(librarian): specify all generated files in remove_regex - #1556

Merged
parthea merged 2 commits into
mainfrom
fix-generation-pubsub
Nov 6, 2025
Merged

parthea merged 2 commits into
mainfrom
fix-generation-pubsub

Conversation

@parthea

@parthea parthea commented Nov 6, 2025 •

Copy link
Copy Markdown
Contributor

This PR resolves the following issue when running librarian generate. Librarian now prevents generated files from clobbering existing files. All generated files must match remove_regex otherwise we will see errors like file existed in destination

time=2025-11-06T20:18:57.185Z level=INFO msg="=== Docker end ================================================================="
time=2025-11-06T20:18:57.185Z level=INFO msg="cleaning directories" "source roots"=[.]
time=2025-11-06T20:18:57.200Z level=INFO msg="copying library files" id=google-cloud-pubsub destination=/usr/local/google/home/partheniou/git/python-pubsub source=/tmp/librarian-2318048050/output/google-cloud-pubsub
time=2025-11-06T20:18:57.201Z level=ERROR msg="failed to generate library" id=google-cloud-pubsub err="file existed in destination: /usr/local/google/home/partheniou/git/python-pubsub/.coveragerc"
time=2025-11-06T20:18:57.201Z level=INFO msg="generation statistics" all=1 successes=0 skipped=0 failures=1
time=2025-11-06T20:18:57.201Z level=ERROR msg="librarian command failed" err="all 1 libraries failed to generate (skipped: 0)"

Command used

librarian generate --generate-unchanged

@parthea
parthea requested review from a team November 6, 2025 20:21
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Nov 6, 2025
@parthea
parthea enabled auto-merge (squash) November 6, 2025 20:46
@parthea
parthea merged commit 54e4a46 into main Nov 6, 2025
28 of 29 checks passed
@parthea
parthea deleted the fix-generation-pubsub branch November 6, 2025 20:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants