Repository navigation
fix(storage): rename ByteBuffer to ByteChunk and hide NIOCore from public API - #1024
Merged
Merged
Conversation
…blic API Rename `GoogleCloudStorage.ByteBuffer` to `ByteChunk` (and conform it to `ContiguousBytes`) so that it does not shadow or get confused with `NIOCore.ByteBuffer` in compiler diagnostics and consumer code. Make all `NIOCore.ByteBuffer` and `NIOHTTP1` initializers, properties, and helpers (`ByteChunk.init(_: NIOCore.ByteBuffer)`, `ByteChunk.byteBuffer`, `StreamSource.init(sequence:) where S.Element == NIOCore.ByteBuffer`, and `StorageClient.parseReadObjectMetadata`) `internal` so that `swift-nio` types are completely encapsulated within `GoogleCloudStorage`. Fixes googleapis#973
chingor13
changed the title
coryan
approved these changes
Sep 22, 2026
coryan
requested changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
GoogleCloudStorage.ByteBuffertoByteChunk(and conform it toContiguousBytes) so that it does not shadow or get confused withNIOCore.ByteBufferin compiler diagnostics and consumer code. Make allNIOCore.ByteBufferandNIOHTTP1initializers, properties, and helpers (ByteChunk.init(_: NIOCore.ByteBuffer),ByteChunk.byteBuffer,StreamSource.init(sequence:) where S.Element == NIOCore.ByteBuffer, andStorageClient.parseReadObjectMetadata)internalso thatswift-niotypes are completely encapsulated withinGoogleCloudStorage. Fixes #973