Conversation
809615f to
d186a68
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces chunk-level retry capabilities for resumable uploads. It adds ChunkAttemptCallable to handle individual chunk transmission attempts, integrates it with ScheduledRetryingExecutor and RetryAlgorithm inside ResumableUploadChunkCoordinator, and adds comprehensive unit tests. A critical issue was identified in ChunkAttemptCallableTest.java where a missing import for org.mockito.ArgumentCaptor will cause compilation failures.
| import static org.mockito.Mockito.when; | ||
|
|
||
| import com.google.api.core.ApiFuture; |
There was a problem hiding this comment.
Missing import for org.mockito.ArgumentCaptor which is used in the test cases.
| import static org.mockito.Mockito.when; | |
| import com.google.api.core.ApiFuture; | |
| import static org.mockito.Mockito.when; | |
| import org.mockito.ArgumentCaptor; | |
| import com.google.api.core.ApiFuture; |
d186a68 to
cbbeb54
Compare
7c209f2 to
ce8a9f5
Compare
ce8a9f5 to
896cd2f
Compare
Wraps chunk uploads in a retrying executor to retry transient network and server errors using exponential backoff. Retries individual chunks without restarting the entire upload session.
896cd2f to
41d94b6
Compare
|
|
1 participant
Wraps chunk uploads in a retrying executor to retry transient network and server errors using exponential backoff. Retries individual chunks without restarting the entire upload session.