Fix XLA --> TSL header layering violation.#3582
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
copybara-service
Bot
force-pushed
the
test_932653625
branch
2 times, most recently
from
0615f53 to
0c5597c
Compare
We can't have XLA depend directly on exported filegroup headers in TSL. Bazel builds need proper cc-dependencies to properly propagate CC build attributes and include directories. PiperOrigin-RevId: 932653625
copybara-service
Bot
force-pushed
the
test_932653625
branch
from
0c5597c to
fb68618
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix XLA --> TSL header layering violation.
We can't have XLA depend directly on exported filegroup headers in TSL.
Bazel builds need proper cc-dependencies to properly propagate CC build
attributes and include directories.