Skip to content

Possible bug in compareEdges #56

Description

@jnyrup

The C++ and Java versions of compareEdges don't match as the C++ compare a1 and b1, while the Java compare b0 and b1.
I guess the C++ version is the correct one?

https://github.com/google/s2geometry/blob/fde443b85c018d2991b7459630932add72ef6f76/src/s2/s2edge_crossings.h#L63

Image

return a0.lessThan(b0) || (a0.equalsPoint(b0) && b0.lessThan(b1));

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions