Skip to content

feat: repo-based allowlist for git enumeration flags - #5797

Open
Ly-Joey wants to merge 7 commits into
google:masterfrom
Ly-Joey:feat-repo-based-cab
Open

feat: repo-based allowlist for git enumeration flags#5797
Ly-Joey wants to merge 7 commits into
google:masterfrom
Ly-Joey:feat-repo-based-cab

Conversation

@Ly-Joey

@Ly-Joey Ly-Joey commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Add repo-based git analysis flags logic in worker before we send the request to gitter to enumerate affected commits.

List of configurable bools:

  • consider_all_branches
  • detect_cherrypicks_intro
  • detect_cherrypicks_fixed
  • detect_cherrypicks_limit

The allowlist is in datastore.
#5800 is the tool to sync the allowlist (in yaml) into datastore entities.

@Ly-Joey
Ly-Joey marked this pull request as ready for review August 6, 2026 01:46
Comment thread go/internal/database/datastore/repo_cab.go Outdated
Comment thread go/internal/database/datastore/repo_cab.go Outdated
Comment thread go/internal/worker/affectedcommits.go Outdated
@Ly-Joey
Ly-Joey force-pushed the feat-repo-based-cab branch from 5f30f10 to 6e3fafa Compare August 7, 2026 01:55
@Ly-Joey Ly-Joey changed the title feat: repo-based consider all branches feat: repo-based allowlist for git enumeration flags Aug 7, 2026
Comment thread go/internal/database/datastore/models.go Outdated
Comment thread go/internal/worker/affectedcommits.go Outdated
}

newURLCache := make(map[string]models.RepoAllowListFlags)
newRegexCache := make(map[string]regexCacheEntry)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still a local cache?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind. Feel free to make it prettier though.

Comment thread go/internal/database/datastore/repo_allowlist.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants