refactor(website): Migrate /list page to go - #5794
Open
michaelkedar wants to merge 2 commits into
Hidden character warning
The head ref may contain hidden characters: "\ud83d\udd78\ufe0f\ud83d\udeab\ud83d\udc0d"
Open
Conversation
another-rex
reviewed
Aug 6, 2026
| <span role="cell" class="vuln-table-cell mdc-data-table__cell"> | ||
| <relative-time datetime="{{ vulnerability.published }}"> | ||
| {{ vulnerability.published | relative_time }} | ||
| <relative-time datetime="{{ .FormattedPublished }}"> |
Contributor
There was a problem hiding this comment.
Can you just make this a span with a title="original date". We can look at this again in the future if the web component make sense to use.
Contributor
There was a problem hiding this comment.
Actually, it looks like we are not even installing the relative-time web component
Comment on lines
+104
to
+115
| result := make([]string, limit) | ||
| for i := range limit { | ||
| pkg := v.Packages[i] | ||
| if pkg.Repo != "" { | ||
| result[i] = stripScheme(pkg.Repo) | ||
| } else if pkg.Package != nil { | ||
| if pkg.Package.GetEcosystem() == "" { | ||
| result[i] = pkg.Package.GetName() | ||
| } else { | ||
| result[i] = pkg.Package.GetEcosystem() + "/" + pkg.Package.GetName() | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe just do append so there won't be empty entries if both parts of the if statement fails (That's probably pretty rare though)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final template migration for the Go website, for the /list page.
Stack created with GitHub Stacks CLI • Give Feedback 💬