Repository navigation
Add front camera screen torch for video capture #641
+308
−25
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| /* | ||
| * Copyright (C) 2026 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.google.jetpackcamera.ui.components.capture | ||
|
|
||
| import androidx.compose.foundation.background | ||
| import androidx.compose.foundation.layout.Box | ||
| import androidx.compose.foundation.layout.fillMaxSize | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.graphics.Color | ||
| import androidx.compose.ui.graphics.toArgb | ||
| import androidx.compose.ui.test.assertHeightIsAtLeast | ||
| import androidx.compose.ui.test.assertWidthIsAtLeast | ||
| import androidx.compose.ui.test.captureToImage | ||
| import androidx.compose.ui.test.getBoundsInRoot | ||
| import androidx.compose.ui.test.hasTestTag | ||
| import androidx.compose.ui.test.junit4.createComposeRule | ||
| import androidx.compose.ui.test.onRoot | ||
| import androidx.compose.ui.unit.height | ||
| import androidx.compose.ui.unit.width | ||
| import androidx.test.ext.junit.runners.AndroidJUnit4 | ||
| import com.google.common.truth.Truth.assertThat | ||
| import kotlinx.coroutines.test.runTest | ||
| import org.junit.Before | ||
| import org.junit.Rule | ||
| import org.junit.Test | ||
| import org.junit.runner.RunWith | ||
|
|
||
| @RunWith(AndroidJUnit4::class) | ||
| class VideoScreenTorchFrameTest { | ||
| @get:Rule | ||
| val composeTestRule = createComposeRule() | ||
|
|
||
| @Before | ||
| fun setUp() { | ||
| composeTestRule.setContent { | ||
| Box( | ||
| modifier = Modifier | ||
| .fillMaxSize() | ||
| .background(Color.Black) | ||
| ) { | ||
| VideoScreenTorchFrame(Modifier.fillMaxSize()) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| fun videoScreenTorchFrame_sizeFillsMaxSize() = runTest { | ||
| composeTestRule.awaitIdle() | ||
| val rootBounds = composeTestRule.onRoot().getBoundsInRoot() | ||
| composeTestRule.onNode(hasTestTag(VIDEO_SCREEN_TORCH_OVERLAY)) | ||
| .assertWidthIsAtLeast(rootBounds.width) | ||
| composeTestRule.onNode(hasTestTag(VIDEO_SCREEN_TORCH_OVERLAY)) | ||
| .assertHeightIsAtLeast(rootBounds.height) | ||
| } | ||
|
|
||
| @Test | ||
| fun videoScreenTorchFrame_borderIsWhiteAndCenterIsNotWhite() = runTest { | ||
| composeTestRule.awaitIdle() | ||
| val frameImage = | ||
| composeTestRule.onNode(hasTestTag(VIDEO_SCREEN_TORCH_OVERLAY)).captureToImage() | ||
|
|
||
| val borderPixel = IntArray(1) | ||
| frameImage.readPixels( | ||
| borderPixel, | ||
| frameImage.width / 2, | ||
| 1, | ||
| 1, | ||
| 1 | ||
| ) | ||
| assertThat(borderPixel[0]).isEqualTo(Color.White.toArgb()) | ||
|
|
||
| val centerPixel = IntArray(1) | ||
| frameImage.readPixels( | ||
| centerPixel, | ||
| frameImage.width / 2, | ||
| frameImage.height / 2, | ||
| 1, | ||
| 1 | ||
| ) | ||
| assertThat(centerPixel[0]).isNotEqualTo(Color.White.toArgb()) | ||
| } | ||
|
Comment on lines
+69
to
+94
Contributor
There was a problem hiding this comment. The test @Test\n fun videoScreenTorchFrame_borderIsWhiteAndCenterIsNotWhite() {\n composeTestRule.awaitIdle()\n val frameImage =\n composeTestRule.onNode(hasTestTag(VIDEO_SCREEN_TORCH_OVERLAY)).captureToImage()\n\n val borderPixel = IntArray(1)\n frameImage.readPixels(\n borderPixel,\n frameImage.width / 2,\n 1,\n 1,\n 1\n )\n assertThat(borderPixel[0]).isEqualTo(Color.White.toArgb())\n\n val centerPixel = IntArray(1)\n frameImage.readPixels(\n centerPixel,\n frameImage.width / 2,\n frameImage.height / 2,\n 1,\n 1\n )\n assertThat(centerPixel[0]).isNotEqualTo(Color.White.toArgb())\n } |
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -35,6 +35,7 @@ const val IMAGE_WELL_TAG = "ImageWellTag" | |||||
|
|
||||||
| const val PREVIEW_DISPLAY = "PreviewDisplay" | ||||||
| const val SCREEN_FLASH_OVERLAY = "ScreenFlashOverlay" | ||||||
| const val VIDEO_SCREEN_TORCH_OVERLAY = "VideoScreenTorchOverlay" | ||||||
|
Contributor
There was a problem hiding this comment. According to the repository style guide (section 10, Test Tags and Semantics), the string value of a test tag must be a
Suggested change
References
|
||||||
| const val AUDIO_INPUT_TOGGLE = "AudioInputToggle" | ||||||
| const val FOCUS_METERING_INDICATOR_TAG = "FocusMeteringIndicatorTag" | ||||||
|
|
||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test
videoScreenTorchFrame_sizeFillsMaxSizedoes not perform any asynchronous operations or coroutine-based assertions. UsingrunTesthere is unnecessary and can be simplified to a standard test function.