Repository navigation
Consolidate JcaFilePathGenerator into configurable DefaultFilePathGenerator - #640
Merged
Merged
Conversation
…erator - Add DefaultFilePathGenerator in :core:common with configurable prefix and relativeOutputPath (defaulting to JCA and DCIM/Camera) - Add DefaultFilePathGeneratorTest Robolectric unit tests - Update AppModule to provide DefaultFilePathGenerator and remove JcaFilePathGenerator - Remove redundant @DefaultFilePathGenerator qualifier from :app
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the file path generation logic by replacing the local JcaFilePathGenerator with a more configurable DefaultFilePathGenerator in the core:common module, and removes the now-redundant @DefaultFilePathGenerator dependency injection qualifier. Additionally, a comprehensive suite of unit tests has been added for the new generator. The feedback suggests optimizing the timestamp generation in DefaultFilePathGenerator by using System.currentTimeMillis() instead of Date().time to avoid unnecessary object allocations.
temcguir
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultFilePathGeneratorin:core:commonwith configurableprefixandrelativeOutputPath(defaulting to"JCA"andDCIM/Camera), allowing client applications to customize output filenames and directory paths while sharing the default implementation.DefaultFilePathGeneratorTestRobolectric unit tests in:core:common.AppModulein:appto provideDefaultFilePathGenerator()and removeJcaFilePathGeneratorand the redundant@DefaultFilePathGeneratorqualifier.