Skip to content

Prevent showing the same PDF for different submissions of the same LOI - #3862

Merged
andreia-ferreira merged 3 commits into
masterfrom
andreia/3823/fix-pdf-namig
Jul 30, 2026
Merged

Prevent showing the same PDF for different submissions of the same LOI#3862
andreia-ferreira merged 3 commits into
masterfrom
andreia/3823/fix-pdf-namig

Conversation

@andreia-ferreira

Copy link
Copy Markdown
Collaborator

There was an edge case where, after a certain submission, if another one was completed within 1 minute, with the same LOI name, the same PDF report as the previous one would show.

This PR fixes that by appending the unique submissionID to the name of the file so that the same report is no longer re-used, as the file names will be different even if the loiName is the same.

@shobhitagarwal1612 PTAL?

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.70%. Comparing base (aa68674) to head (3ceea75).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3862      +/-   ##
============================================
- Coverage     67.72%   67.70%   -0.02%     
+ Complexity     1860     1859       -1     
============================================
  Files           411      411              
  Lines         10860    10857       -3     
  Branches       1425     1425              
============================================
- Hits           7355     7351       -4     
  Misses         2767     2767              
- Partials        738      739       +1     
Files with missing lines Coverage Δ
...oundplatform/feature/pdf/mapper/LoiReportMapper.kt 91.54% <100.00%> (-1.70%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andreia-ferreira
andreia-ferreira merged commit 6837538 into master Jul 30, 2026
20 checks passed
@andreia-ferreira
andreia-ferreira deleted the andreia/3823/fix-pdf-namig branch July 30, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants