Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #799.
Reproduction
With the default text encoding simulated as cp1252, reading UTF-8 YAML containing
caféreturnscafé. Reading anunattend.xmlcontaining a valid UTF-8 combining acute accent raisesUnicodeDecodeErrorbecause byte0x81is undefined in cp1252.Changes
unattend.xmlexplicitly as UTF-8.Verification
In an isolated Python 3.13.16 Docker container with networking disabled and read-only source mounts:
python -m glazier.lib.actions.sysprep_test— 4 tests passed.python -m glazier.lib.config.files_test— 5 tests passed.UnicodeDecodeError, then passed with this change.git diff HEAD^ HEAD --checkpassed.