Repository navigation
Terminate Windows child process tree when ExecTimeout expires. - #810
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
On Windows, `os.Process.Kill()` (`TerminateProcess`) terminates only the immediate process (`cmd.Process`) and leaves descendant child processes running. When `helpers.ExecTimeout` runs a command such as `powershell.exe` or `dism.exe` that spawns child processes (e.g. `DismHost.exe`) and hits `conf.Timeout`, the child processes remain orphaned and continue holding file and CBS/DISM locks indefinitely. Assign started processes on Windows to a Job Object configured with `JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE`, and terminate the Job Object (falling back to `taskkill.exe /T /F /PID` and `proc.Kill()`) when `conf.Timeout` expires so the entire child process tree is cleaned up. PiperOrigin-RevId: 1002421541
copybara-service
Bot
force-pushed
the
test_1002421541
branch
from
October 19, 2026 17:36
af50d47 to
4f0761c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminate Windows child process tree when ExecTimeout expires.
On Windows,
os.Process.Kill()(TerminateProcess) terminates only the immediate process (cmd.Process) and leaves descendant child processes running. Whenhelpers.ExecTimeoutruns a command such aspowershell.exeordism.exethat spawns child processes (e.g.DismHost.exe) and hitsconf.Timeout, the child processes remain orphaned and continue holding file and CBS/DISM locks indefinitely.Assign started processes on Windows to a Job Object configured with
JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE, and terminate the Job Object (falling back totaskkill.exe /T /F /PIDandproc.Kill()) whenconf.Timeoutexpires so the entire child process tree is cleaned up.