Skip to content

Mock check_winpe in test_driver_wim and correct its call expectations. #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MohammedAlkindi wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Mock check_winpe in test_driver_wim and correct its call expectations. #803

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45ac1c7
Mock check_winpe in test_driver_wim and correct its call expectations.
MohammedAlkindi Aug 28, 2026
2a184f9
Merge branch 'master' into fix/drivers-test-host-dependent-winpe
MohammedAlkindi Sep 1, 2026
8ec6188
Merge branch 'master' into fix/drivers-test-host-dependent-winpe
MohammedAlkindi Sep 8, 2026
5ea3e58
Merge branch 'master' into fix/drivers-test-host-dependent-winpe
MohammedAlkindi Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions glazier/lib/actions/drivers_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

class DriversTest(test_utils.GlazierTestCase):

@mock.patch.object(drivers.winpe, 'check_winpe', autospec=True)
@mock.patch.object(BuildInfo, 'ReleasePath')
@mock.patch.object(BuildInfo, 'Branch')
@mock.patch('glazier.lib.download.Download.VerifyShaHash', autospec=True)
Expand All @@ -32,7 +33,7 @@ class DriversTest(test_utils.GlazierTestCase):
@mock.patch.object(drivers.file_util, 'CreateDirectories', autospec=True)
def test_driver_wim(self, mock_createdirectories, mock_execute_binary,
mock_downloadfile, mock_verifyshahash, mock_branch,
mock_releasepath):
mock_releasepath, mock_check_winpe):

bi = BuildInfo()

Expand All @@ -49,6 +50,7 @@ def test_driver_wim(self, mock_createdirectories, mock_execute_binary,
}
mock_branch.return_value = 'stable'
mock_releasepath.return_value = '/'
mock_check_winpe.return_value = False

# Success
dw = drivers.DriverWIM(conf['data']['driver'], bi)
Expand All @@ -62,7 +64,7 @@ def test_driver_wim(self, mock_createdirectories, mock_execute_binary,
cache = drivers.constants.SYS_CACHE
mock_execute_binary.assert_has_calls([
mock.call(
drivers.constants.WINPE_DISM,
drivers.constants.SYS_DISM,
[
'/Mount-Image',
f'/ImageFile:{local}',
Expand All @@ -78,7 +80,7 @@ def test_driver_wim(self, mock_createdirectories, mock_execute_binary,
shell=False,
),
mock.call(
drivers.constants.WINPE_DISM,
drivers.constants.SYS_DISM,
['/Unmount-Image', f'/MountDir:{cache}\\Drivers\\', '/Discard'],
shell=False,
),
Expand Down
Loading