Skip to content

macOS: normalize SHM names and propagate blob creation failures#151

Open
jovemexausto wants to merge 2 commits into
google:mainfrom
jovemexausto:capivara/macos-shm-fix
Open

macOS: normalize SHM names and propagate blob creation failures#151
jovemexausto wants to merge 2 commits into
google:mainfrom
jovemexausto:capivara/macos-shm-fix

Conversation

@jovemexausto

Copy link
Copy Markdown

Summary

  • Normalize POSIX shared-memory names on macOS before calling shm_open().
  • Propagate the return value from stream_renderer_create_blob() instead of always reporting success.

Why

These fixes make blob-backed GPU resources fail loudly and keep macOS SHM creation compatible with the expected POSIX naming rules.

Validation

  • Rebuilt gfxstream locally on macOS.
  • Exercised this path as part of the macOS/libkrun Android integration work.

@google-cla

google-cla Bot commented Jun 23, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Signed-off-by: Marcus Figueiredo <figueiredo@protonmail.com>
Signed-off-by: Marcus Figueiredo <figueiredo@protonmail.com>
@jovemexausto jovemexausto force-pushed the capivara/macos-shm-fix branch from 367ef17 to 273e368 Compare June 23, 2026 02:16
@jovemexausto jovemexausto reopened this Jun 23, 2026
@jovemexausto

Copy link
Copy Markdown
Author

Reopened after signing the CLA. I hope this fix is useful to the project; it was essential for my current research, and I’m happy to help with any follow-up.

@jovemexausto

Copy link
Copy Markdown
Author

The companion patch in libkrun is here. Together they unblock the macOS gfxstream blob-mapping path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant