macOS: normalize SHM names and propagate blob creation failures#151
Open
jovemexausto wants to merge 2 commits into
Open
macOS: normalize SHM names and propagate blob creation failures#151jovemexausto wants to merge 2 commits into
jovemexausto wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed-off-by: Marcus Figueiredo <figueiredo@protonmail.com>
Signed-off-by: Marcus Figueiredo <figueiredo@protonmail.com>
367ef17 to
273e368
Compare
Author
|
Reopened after signing the CLA. I hope this fix is useful to the project; it was essential for my current research, and I’m happy to help with any follow-up. |
Author
|
The companion patch in libkrun is here. Together they unblock the macOS gfxstream blob-mapping path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shm_open().stream_renderer_create_blob()instead of always reporting success.Why
These fixes make blob-backed GPU resources fail loudly and keep macOS SHM creation compatible with the expected POSIX naming rules.
Validation