Bazel backdating#3223
Draft
mgeisler wants to merge 3 commits into
Draft
Conversation
This moves the remaining two tools into Bazel: `i18n-report` and
`mdbook` itself. They are still installed with
cargo xtask install-tools
to make this less disruptive. This will go away as we start using the
`mdbook` rule in Bazel to build the many books.
This ensures that future use of the `mdbook` rule will use `mdbook` version 5.0.3 to match #3207.
bazel: add repository rule to generate per-renderer book.toml When `mdbook` is running, it renders output for each of the `output` keys. This happens sequentially and we need different output for different cases: | Renderer | English | Translations | Use Case | | ------------ | ------- | ------------ | --------------------------- | | `html` | ✓ | ✓ | Website HTML output | | `pandoc` | ✓ | ✓ | PDF generation | | `exerciser` | ✓ | ✗ | Exercise starter code | | `xgettext` | ✓ | ✗ | `.pot` file for translators | | `linkcheck2` | ✓ | ✗ | Link validation in CI | This little repository rule is a step towards this: it lets us trim the `book.toml` file down to the renderers we want to each case. We can thus keep maintaining the overall set of renderers in the checked in `book.toml` file, and then select a subset of the settings at build time.
mgeisler
force-pushed
the
bazel-backdating
branch
from
04d879b to
a5bd5ae
Compare
Collaborator
Author
|
From this infrastructure, it's a small step to make a The complexity is still there... but it's now suddenly in a form that allows us to reproduce things locally that we could not really do easily today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @qwandor and @djmitche, this is a WIP of where I'm taking the project. On this branch,
produces a Danish book!
I've been spinning off small bits and pieces of this WIP commit over the last few weeks in the PRs you've reviewed.