Fix risk of accepting packets before firmware is loaded#948
Open
typenoob wants to merge 1 commit into
Open
Conversation
Author
|
I believe you can reproduce this issue on Windows by first putting the remote device into pairing mode, and then calling the Intel Bluetooth adapter's |
Author
|
Testing, linting, and formatting were not performed yet. |
5d8beda to
edcce82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an error that occurs when a remote device repeatedly sends HCI_CONNECTION_REQUEST_COMMAND early while the local device still needs to load its firmware driver:
The root cause is that
Host.readywas incorrectly set to True before the firmware driver had finished loading successfully.In addition, I believe letting Drivers control
Host.readyis risky, so this behavior has been consolidated and moved intoHost.resetinstead.