CIG: Fix CIG parameters for unidirectional CIS#943
Open
uier wants to merge 1 commit into
Open
Conversation
When setting up a CIG for a unidirectional CIS (e.g., Central-to-Peripheral only), the unused direction's max SDU size is set to 0. However, the other parameters (retransmission count and PHY) defaulted to non-zero values. This caused controllers to reject the configuration during CIG setup or CIS establishment with error 0x30 (Parameter Out Of Mandatory Range). This change resets the retransmission count and PHY to 0 for any direction where max SDU is 0. A test_cis_parameters_unidirectional test is included with this change. This commit also fixes parameterize decorator syntax in several test files to resolve test collection failures in Python 3.13 / pytest 8.
zxzxwu
reviewed
Jun 24, 2026
| rtn_p_to_c: int = DEVICE_DEFAULT_ISO_CIS_RTN # Number of P->C retransmissions | ||
|
|
||
| def __post_init__(self) -> None: | ||
| if self.max_sdu_c_to_p == 0: |
Collaborator
There was a problem hiding this comment.
Need a comment here explaining the reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting up a CIG for a unidirectional CIS (e.g., Central-to-Peripheral only), the unused direction's max SDU size is set to 0. However, the other parameters (retransmission count and PHY) defaulted to non-zero values. This caused controllers to reject the configuration during CIG setup or CIS establishment with error 0x30 (Parameter Out Of Mandatory Range).
This change resets the retransmission count and PHY to 0 for any direction where max SDU is 0. A test_cis_parameters_unidirectional test is included with this change.
This commit also fixes parameterize decorator syntax in several test files to resolve test collection failures in Python 3.13 / pytest 8.