Repository navigation
fix(tree): accept quoted skill names during validation - #157
Open
OUAO-FRANK wants to merge 1 commit into
Open
OUAO-FRANK wants to merge 1 commit into
OUAO-FRANK wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tree validation rejects
name: "invoice-review"andname: 'invoice-review'even though both pinned substrates parse them as the directory name. Accept those two spellings alongside the bare name, so a valid skill proposal reaches the existing adapter validation.Different names and unbalanced quotes remain rejected. Codex's optional-name behavior is preserved. This is a narrow spelling check; it adds no YAML dependency or general frontmatter parser.
Fixes #156.
Validation:
python -B -m unittest discover -s tests -p test_skill_names.py -v: all 4 tests pass on Windows/Python 3.12.12, covering both surfaces, quoted and bare matching names, mismatches, malformed quotes, optional names, and proposal acceptance.python3 -B -m unittest discover -s tests -v: all 9 tests pass under WSL/Linux/Python 3.12.3.ruff check harness2 tests,ruff format --check harness2/core/tree.py tests/test_skill_names.py, andgit diff --check: pass.tree.pyin memory after the fix reproduces exactly those failures, while the mismatch and optional-name controls pass. The working tree stays fixed.Checked the pinned Codex YAML loader and OpenCode markdown parser linked in the issue. No model calls or benchmark credentials are needed for these tests.