Skip to content

fix(examples): remove unsafe eval in title.sh and update documentation links - #774

Closed
omen18 wants to merge 1 commit into
google-antigravity:mainfrom
omen18:fix/title-eval-and-doc-links
Closed

omen18 wants to merge 1 commit into
google-antigravity:mainfrom
omen18:fix/title-eval-and-doc-links

Conversation

@omen18

@omen18 omen18 commented Aug 10, 2026

Copy link
Copy Markdown

Summary

  • Security/Safety Fix: Replaced unsafe eval invocation in examples/title/title.sh with safe jq -r line reading. Previously, eval $(echo "$DATA" | jq -r ...) could evaluate arbitrary strings/commands if workspace path contained special characters or quotes.
  • Documentation Fix: Fixed broken documentation links in examples/title/README.md (cli-title -> cli/title) and examples/statusline/README.md (cli-statusline -> cli/statusline).

Verification

  • Tested title.sh with normal JSON payload, CitC workspace path payload, and payload with spaces & quotes.

@google-cla

google-cla Bot commented Aug 10, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@omen18 omen18 closed this by deleting the head repository Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant