Repository navigation
fix(statusline): handle CRLF input and invalid numeric fields - #1164
Open
bhogesararam23 wants to merge 1 commit into
Open
bhogesararam23 wants to merge 1 commit into
bhogesararam23 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
examples/statusline/statusline.shfailing on Windows whenjqproduces CRLF-terminated output.The trailing
\rcharacters were being passed into parsed fields, causing numeric formatting and comparisons to fail and leaving the statusline blank.This also makes malformed or incomplete statusline input degrade gracefully instead of terminating under
set -euo pipefail.Changes
0–100range.Validation
Tested with Git Bash and native Windows
jq1.7.1:bash -n— passedHEAD— 5/5 identicaljqfallback — degraded output, exit 0git diff --check— cleanThe failing Windows case was reproduced against the unmodified version and verified to render correctly after the fix.
Scope
Only
examples/statusline/statusline.shis modified.No dependencies are added, and no intentional behavior changes were made for valid Unix/LF input.