fix: fall back after image transport init failure - #319
Open
Eljees wants to merge 1 commit into
Open
Conversation
Signed-off-by: Eljees <3.14hell@gmail.com>
Eljees
force-pushed
the
agent/fix-digest-transport-fallback
branch
from
July 29, 2026 18:57
feb95b7 to
af97950
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Dockle tries
docker-daemon:beforedocker://. For a locally pulled image referenced by its registry manifest digest, the daemon source opens butimage.FromSourcerejects the locally reconstructed manifest.newSourcereturned that error immediately instead of trying the registry transport already present in the fallback list.Testing
CGO_ENABLED=0 go test ./pkg/deckoder/extractor/... -count=1CGO_ENABLED=0 go vet ./pkg/deckoder/extractor/...alpine@sha256:5b10f432ef3da1b8d4c7eb6c487f2f5a8f096bc91145e68878dd4a5019afde11: current master fails withManifest does not match provided manifest digest; this branch completes the scanFixes #262