Value type refactoring 5#3629
Open
vigoo wants to merge 41 commits into
Open
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019eb504-80dd-723a-b519-2fc53141eb19 Co-authored-by: Amp <amp@ampcode.com>
✅ Deploy Preview for golemcloud canceled.
|
|
📖 Docs preview: https://docs-d21wx2fjb-golem-cloud.vercel.app Built from commit |
7 tasks
|
Found 1 test failure on Blacksmith runners: Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3399
Resolves #3400
Resolves #3401
Resolves #3402
Resolves #3403
Resolves #3405
This almost closes the schema refactor, the only remaining step is #3404 (and #3529) that starts using the new rich types for quota tokens, secrets etc.
Note: also contains support for non-standard cargo target dirs in various places (in makefile, golem-cli etc) which is unrelated to the schema refactoring, but was needed to be able to work on this in more parallel tracks with an external drive.