Make path CSGPolygon3D dirty when entering tree - #123148
Open
DeeJayLSP wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
If a
CSGPolygon3Dset toMODE_PATHgets removed from tree, it also gets disconnected from its path to stop updating.When it is re-added, however, it's never told to re-connect, unless collisions are enabled (in which case
CSGShape3D::_notification()will handle it), or we do something to manually make it dirty (like setting it toMODE_PATHagain immediately after it re-enters the tree).The simplest fix I found was to call
_make_dirty()when re-entering the tree, specifically forCSGPolygon3Dwhen it'sMODE_PATH. The check for collision usage is just to ensure it won't mark it as dirty twice.Additional information
Reproduction project
Same as the issue, but modified for demonstration: csg_polygon_exit_enter_bug.zip
Before fix
before.mp4
One still works because, as mentioned, it's set to
MODE_PATHagain which marks it as dirty.After fix
after.mp4