Skip to content

Add auto-merge for client-library-templates changes - #233

Open
jamiecobbett wants to merge 2 commits into
masterfrom
add-auto-merge-template-changes-workflow
Open

Add auto-merge for client-library-templates changes#233
jamiecobbett wants to merge 2 commits into
masterfrom
add-auto-merge-template-changes-workflow

Conversation

@jamiecobbett

Copy link
Copy Markdown
Contributor

Summary

  • Adds a caller workflow (schedule + workflow_dispatch) that invokes the reusable auto-merge-client-library-changes workflow in gocardless/github-actions (see gocardless/github-actions#503).
  • That workflow merges the automated "Changes from gocardless/client-library-templates" PR once 24h have passed since the last commit was pushed to it.

Context

gocardless-ci-robot now bypasses the review requirement (but not required status checks) on this repo's branch protection (gocardless/anu#48800), so it can merge these PRs on its own once that lands. This workflow won't actually be able to merge anything until that PR is applied.

Test plan

  • Validated YAML syntax
  • Validated the reusable workflow's discovery/age logic against this repo's real open template-changes PR (see gocardless/github-actions#503 for details)
  • Depends on gocardless/anu#48800 being merged and applied before it can do anything

Calls the reusable workflow in gocardless/github-actions that merges
the automated "Changes from gocardless/client-library-templates" PR
24h after the last change was pushed to it, once gocardless-ci-robot's
review-requirement bypass is live (gocardless/anu#48800). Runs hourly
via schedule since the reusable workflow's own delay logic decides
whether it's actually ready to merge.
Terraform's required_status_checks matches on the job's display name
(name:), not its YAML key. The aggregator job here was named "All tests
passed" while anu's branch protection requires "all-tests-passed",
so the required check never reports and PRs stay blocked forever
despite the underlying job passing (see #193).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants