Skip to content

fix: restore main CI after module path rename merge skew - #696

Merged
compscidr merged 1 commit into
mainfrom
fix/stale-module-imports
Oct 18, 2026
Merged

compscidr merged 1 commit into
mainfrom
fix/stale-module-imports

Conversation

@compscidr

Copy link
Copy Markdown
Collaborator

Main has been red since #687 renamed the module to github.com/goblogplatform/goblog. PRs branched earlier (#688–#693) merged with old goblog/... imports.

Verified locally: go build ./... and go test -race ./... pass.

🤖 Generated with Claude Code

PRs branched before the module path rename (#687) still imported
goblog/..., and two new tests built their own FuncMap without commaList
(added in #685). Use the module path and theme.FuncMap().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are mechanical module-path import rewrites plus a FuncMap switch that matches the established pattern at every other call site, and I verified completeness with no stale imports or compile issues remaining.

No open issues 🎉

What changed in this PR

This PR restores the main branch CI, which went red after #687 renamed the Go module to github.com/goblogplatform/goblog. PRs branched before that rename (#688–#693) merged with stale goblog/... import lines. The PR rewrites those stale imports to the new module path and, in two tests, replaces a hand-rolled template FuncMap (which was missing the commaList function introduced by #685) with the canonical theme.FuncMap().

I verified:

  • The module path in go.mod is github.com/goblogplatform/goblog, matching the rewritten imports.
  • theme.FuncMap() (theme/load.go:26-41) provides both rawHTML and commaList; commaList is referenced by templates/shared/_head.html:98, so the previous hand-rolled maps would have failed ParseGlob. The switch is correct and necessary.
  • The two changed test files are external test packages (blog_test, admin_test), so adding the theme import introduces no import cycle.
  • All remaining goblog/... occurrences are the intentional Yaegi alias strings (plugin/symbols.go, loader_test.go, validate_test.go, hello.go.example) left untouched as described, not real imports.
  • Completeness: all other template-parsing test sites already use theme.FuncMap(), so no other test file remains broken.

Changes:

  • Rewrite stale goblog/... import lines to the github.com/goblogplatform/goblog/... module path across several (mostly test) files.
  • Switch blog/post_type_test.go and admin/crud_validation_test.go to theme.FuncMap() to pick up the commaList template function.
File Description
wizard/​handlers_test.go Rewrites datadir import to module path
tools/​seed_backlinks_test.go Rewrites blog/tools imports to module path
plugin/​wasm/​contract.go Rewrites plugin import to module path
plugin/​posts.go Rewrites blog import to module path
plugin/​posts_test.go Rewrites blog/plugin imports to module path
blog/​post_type_test.go Module-path imports + switches to theme.FuncMap() for commaList
admin/​settings_api_test.go Rewrites admin/auth/blog/plugin imports to module path
admin/​login_methods.go Rewrites datadir import to module path
admin/​login_methods_test.go Rewrites admin/blog/datadir imports to module path
admin/​crud_validation_test.go Module-path imports + switches to theme.FuncMap() for commaList

Review effort: Balanced

@codecov

codecov Bot commented Oct 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@compscidr
compscidr merged commit cb235c2 into main Oct 18, 2026
7 of 8 checks passed
@compscidr
compscidr deleted the fix/stale-module-imports branch October 18, 2026 03:38
compscidr added a commit that referenced this pull request Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants