Repository navigation
fix: restart reader after server declines StartTLS - #645
Open
netliomax25-code wants to merge 1 commit into
Open
netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StartTLSsends its request with the startTLS flag, so the reader goroutine stops as soon as it has delivered the response and the TLS handshake can take over the socket. The reader is only restarted on the success path, after the handshake.Validation:
TestStartTLSRejectedKeepsReaderdrives StartTLS over the in-package fake connection, has the server decline it and checks a following WhoAmI gets its reply. It fails on master and passes with the fix.go vet,golangci-lintandgo test -race ./...against the test directory server pass.