Repository navigation
fix: stop EscapeDN and PostalAddress.Escape corrupting invalid UTF-8 - #642
Open
netliomax25-code wants to merge 1 commit into
Open
netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EscapeDNandPostalAddress.Escapewalk their input with a rune range loop, so a byte that is not part of a valid UTF-8 sequence ranges asutf8.RuneErrorand is written back as U+FFFD.EscapeDN("\xeb")andEscapeDN("\xef\xbf\xbd")return the same string, so two different values an application escapes into a bind or search DN collide onto one DN, and non-UTF-8 input (e.g. latin-1 text) is silently corrupted instead of escaped.EscapeDNnow emits the RFC 4514 section 2.4 hex pair for such a byte (\eb), whichParseDNalready decodes back to the original octet.PostalAddress.Escapeiterates bytes instead, since RFC 4517 defines no general hex escape there andParsePostalAddressreads bytes, so every octet round-trips. Escaping of valid UTF-8 input is unchanged. Found with a fuzzer asserting that escape-then-parse returns the original value; regression tests added for both helpers.This fix was found and prepared with AI assistance and reviewed by me before submitting.