Repository navigation
Conversation
cpuschma
force-pushed
the
feature/srv-records
branch
from
September 28, 2026 21:14
f522eb8 to
1b2b160
Compare
cpuschma
marked this pull request as ready for review
September 28, 2026 21:15
yrro
reviewed
Oct 12, 2026
| // DialWithSRVDiscovery makes DialURL resolve the host through DNS SRV records | ||
| // (RFC 2782) and connect to the returned targets in RFC 2782 order until one | ||
| // connection succeeds. The service name is derived from the URL scheme | ||
| // (_ldap._tcp for ldap://, _ldaps._tcp for ldaps://) and the port from the SRV |
There was a problem hiding this comment.
In practice, neither Active Directory nor FreeIPA maintain _ldaps._tcp.example.com SRV records. For clients that want to use port 636 with tls-on-connect, the conventino is to a lookup for _ldap._tcp.example.com and ignore the port number in the SRV record.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for resolving LDAP servers through SRV records, following the specifications of RFC2782 and adds a new public function
LookupSRVto obtain available records by hand.It adds a new
DialOpt, so it's use is optional and disabled by default. By default Go'snet.DefaultResolveris used, but a custom resolver can be used too.Closes #329.