Refactor tests by httptest suite - #5
Merged
Merged
Conversation
Signed-off-by: Chen Su <ghosind@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR refactors the engine’s test adapters to use Go’s net/http/httptest primitives, making request/response behavior in tests closer to real HTTP semantics.
Changes:
- Reworked the test
Requestadapter to wrap*http.Requestand derive fields (headers, cookies, URL, client IP) from it. - Reworked the test
Responseadapter to wrap anhttp.ResponseWriter(typicallyhttptest.ResponseRecorder) and added a helper to flush buffered writes. - Updated
context_test.goto build contexts fromhttptest.NewRequest/httptest.NewRecorderinstead of manually mutating stub fields.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| engine_test.go | Refactors test Request/Response adapters to delegate to *http.Request / http.ResponseWriter and adds a send() flush helper. |
| context_test.go | Updates context tests to construct requests/responses via httptest and validate behavior using recorder output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+100
to
+101
| func (r *Response) Status(code int) { r.code = code } | ||
| func (r *Response) StatusCode() int { return r.code } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.