feat: expose zIndex and holes on Polyline and Polygon - #153
dyk1454683243-sudo wants to merge 1 commit into
Conversation
Forward child zIndex and polygon holes through overlay collection so hand-written shapes match GeoJSON and bulk descriptor support. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
|
Warning Review limit reachedNext included review available in 43 minutes. View limit detailsLimit details: You’ve used the included review currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
What does this change?
PolylineDescriptorandPolygonDescriptoralready carryzIndex, andPolygonDescriptoralready carriesholes. The JSX prop types and overlay collectors did not, so holes worked through<Geojson>and the bulkpolygonsprop but a hand-written<Polygon>could not express one.This adds:
zIndex?: numberonPolylinePropsandPolygonPropsholes?: Coordinate[][]onPolygonPropsand forwards
props.zIndex/props.holesthroughcollectOverlayChildinto the pushed descriptors. Equality comparators already compare these fields (#117), so updates reach native.zIndexJSDoc notes it is Google-provider only — Apple MapKit does not expose shape overlay z-ordering (same wording asdocs/geojson.md). README shape documentation is updated.Fixes #97
How was it verified?
zIndex, a two-ring polygon (holes+zIndex), and omitted fields staying unsetbun run --filter react-native-better-maps test— 184 pass, 0 failbun run typecheck— passbun run typecheck:provider-types— passbun run lint— passNo Nitrogen, Swift, or Kotlin changes.
bun run nitrogenwas not run (CI codegen is unchanged).Scope
zIndexis Google-only; holes are forwarded at the JS layer for all providersChecklist
bun run lintandbun run typecheckpass (bun run buildskipped — it runs Nitrogen viaprebuild)