feat: stamp service.instance.id on spans and share it with the heartbeat - #24
Merged
Merged
Conversation
One uuid per client, minted at init before the provider is built: stamped as the service.instance.id resource attribute on every span and injected into HeartbeatSender so heartbeat payloads carry the same identity. The backend can now join heartbeats to traces and count replicas. Stamped unconditionally (heartbeat off included). Workers spawned after init() should init() themselves for exact per-worker span identity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes RIUS-436 (TypeScript side; wire contract identical to the Python PR: glassflow/rius-sdk-python#63).
What
One uuid per client, minted in
init()before the provider is built:service.instance.id(standard OTel semconv), so every exported span carries it.HeartbeatSender(now a required option) instead of the sender minting its own, so heartbeat payloads carry the same identity.The backend can now join heartbeats to traces and count replicas sharing one
agent_name.Decisions
init()(cluster/fork patterns) shouldinit()themselves for exact per-worker span identity; noted in the code.Tests
New cases in
tests/client.test.ts(written first, watched fail):instance_id== span resource attribute (injected exporter + transport)heartbeat: falseThe former "fresh instanceId per sender" test now asserts the sender carries the injected identity.
All gates green: vitest (224 passed), biome, tsc, build.