fix(ci): read tool versions from .mise.toml via mise-action - #119
Conversation
.nvmrc was removed in favour of .mise.toml, breaking the Setup Node.js step. Install node (and ruby for iOS jobs) with jdx/mise-action instead; Yarn stays vendored via yarnPath. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe composite Setup action now uses ChangesCI Tool Setup
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The setup action now selects tools through mise, and the iOS workflows request Node and Ruby. Yarn remains available through the hosted runners and uses the vendored project version, leaving no material merge-readiness concern. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
CI broke after #114 removed
.nvmrc: every job failed at "Setup Node.js" becauseactions/setup-nodewas still readingnode-version-file: .nvmrc..github/actions/setup/action.yml): replacesactions/setup-nodewithjdx/mise-action(pinned by SHA, v4.3.0). A newtoolsinput (defaultnode) is passed tomise install. Yarn is left out of mise because the vendored.yarn/releases/yarn-4.11.0.cjsis used throughyarnPath.pr.yml,release.yml): passtools: node ruby, so CocoaPods runs on Ruby 3.4.4 from.mise.tomlinstead of the runner's Homebrew Ruby..mise.toml:[min_version] mise = \"2024\"is invalid in current mise ("unknown fieldmise, expectedhardorsoft"), so it is nowmin_version = \"2024.1.0\".Verification
PR Validation run on this branch: https://github.com/gladiuscode/react-native-orientation-director/actions/runs/36407890098
pod install(React-Core-prebuiltdiffers fromPods/Local Podspecs, and the lockfile was generated with CocoaPods 1.16.2 whileexample/Gemfile.lockpins 1.14.3). This is not caused by this change: there has been no passing iOS run since the RN 0.86 / Expo SDK 56 upgrades. It will be handled separately.🤖 Generated with Claude Code
Summary by CodeRabbit