Skip to content

[BUG] Expo plugin breaking due to override keyword needing to be public in version 54 #93

Description

@survivorsam

Describe the bug
When loading the plugin (for iOS) in version 54, compilation fails due to the lack of "public override" prefixing the application method.

Expected behavior
It should use the public override keyword in version 54.

Additional information
The code in ios/TestApp/AppDelegate.swift should look like this:

public override func application(_ application: UIApplication, supportedInterfaceOrientationsFor window: UIWindow?) -> UIInterfaceOrientationMask {
    return OrientationDirector.getSupportedInterfaceOrientationsForWindow()
  }

My apologies for suggesting expo 54 did not need "public override" at all yesterday.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions