fix(asyncgit): correct swapped current/total in pack_progress callback#2973
Open
Noethix55555 wants to merge 1 commit into
Open
fix(asyncgit): correct swapped current/total in pack_progress callback#2973Noethix55555 wants to merge 1 commit into
Noethix55555 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callbacks::callbacksregisters apack_progressclosure that receives(stage, current, total)from git2 but forwards them as(stage, total, current)to the privatepack_progressmethod. The method's parameter names then label the git2currentastotaland vice versa, soProgressNotification::Packing { current, total }is emitted with the values inverted.This makes the packing progress bar count from ~100% down to 0% (or saturate immediately) instead of advancing from 0% to 100%.
Fix: pass
current, totalin the correct order and align the private method's parameter names to match.