You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Two defects in workflows/squad-implement-worker.md that the review gate depends on:
No machine-readable provenance. A Squad-authored PR is identifiable only by the squad/implement-* head branch prefix. Branch names are mutable and a bot login is ambiguous once other automation opens PRs. The reviewer needs a durable marker.
Merge relay is under-constrained. The pull_request: [closed] relay fires when merged == true and the head branch prefix matches, but does not verify the PR merged into the default branch. A merge into a scratch or stacked branch advances the epic as though the work had landed. The relay also drops aw_context, losing correlation between the merged PR run and the re-dispatch.
Scope
workflows/squad-implement-worker.md only.
Acceptance criteria
Worker PR bodies include a provenance marker, e.g. <!-- squad:implement issue=N run=<run_id> -->, emitted on every created PR.
Merge relay if condition additionally requires the PR base to equal the repository default branch.
Relay preserves aw_context through the re-dispatch.
Tests assert the marker format, the base-branch condition, and aw_context propagation.
Notes
The relay dispatches with target-ref: ${{ github.event.repository.default_branch }} because merged head branches may be deleted. That is correct and should not change. This issue constrains when the relay fires, not what ref it targets.
Owner: EECOM (squad:eecom). This lives in the implement-worker relay/provenance path and needs core workflow/runtime ownership rather than prompt-router ownership.
Files in scope
Verified existing paths:
workflows\squad-implement-worker.md
est\gh-aw-implement-workflow.test.ts
Prompt-budget impact
No direct workflows\squad.md impact: +0 KB to the router prompt. Router headroom remains 37,602 B unless a later phase spends it.
A structural test must fail if the PR body lacks , if the relay can fire for a non-default base branch, or if �w_context is dropped. A substring-only smoke test is not a gate.
Out of scope
The reviewer workflow, required-check enforcement, remediation, and documentation.
Session-stall guard
Before starting: this repo has phantom CRLF diffs (#1793). If git status shows files modified that you did not touch, run git diff --ignore-cr-at-eol. If that output is empty, the diff is line-ending churn, not real edits — run git add --renormalize . and continue. Do not halt and ask for confirmation; halting on phantom diffs is the documented cause of stuck sessions in this repo.
Activity
github-actions commentedon Aug 17, 2026
📋 Assigned to EECOM (Core Dev)
Issue: #1731 — Phase 0b: Add PR provenance marker and tighten implement-worker merge relay
EECOM will pick this up in the next Copilot session.
bradygaster commentedon Aug 23, 2026
Procedures triage brief — Phase 0b
Owner & rationale
Owner: EECOM (squad:eecom). This lives in the implement-worker relay/provenance path and needs core workflow/runtime ownership rather than prompt-router ownership.
Files in scope
Verified existing paths:
Prompt-budget impact
No direct workflows\squad.md impact: +0 KB to the router prompt. Router headroom remains 37,602 B unless a later phase spends it.
Dependencies
Verification bar
A structural test must fail if the PR body lacks , if the relay can fire for a non-default base branch, or if �w_context is dropped. A substring-only smoke test is not a gate.
Out of scope
The reviewer workflow, required-check enforcement, remediation, and documentation.
Session-stall guard
Before starting: this repo has phantom CRLF diffs (#1793). If
git statusshows files modified that you did not touch, rungit diff --ignore-cr-at-eol. If that output is empty, the diff is line-ending churn, not real edits — rungit add --renormalize .and continue. Do not halt and ask for confirmation; halting on phantom diffs is the documented cause of stuck sessions in this repo.test(workflows): parse compiled config by heredoc
fix(workflows): harden implement relay provenance (github#1869)