Finish test for catalogs

Author: Kevin Paulisse

lib/octocatalog-diff/util/catalogs.rb

@@ -115,7 +115,11 @@ def build_catalog_parallelizer
         # Things have succeeded if the :to and :from catalogs exist at this point. If not, things have
         # failed, and an exception should be thrown.
         return result if result.key?(:to) && result.key?(:from)
+
+        # This is believed to be a bug condition.
+        # :nocov:
         raise OctocatalogDiff::Errors::CatalogError, 'One or more catalogs failed to compile.'
+        # :nocov:
       end
 
       # Get catalog compilation tasks.

spec/octocatalog-diff/tests/util/catalogs_spec.rb

@@ -294,17 +294,18 @@ def valid?
     it 'should raise OctocatalogDiff::Errors::CatalogError if either catalog fails' do
       options = {
         to_catalog: OctocatalogDiff::Spec.fixture_path('catalogs/tiny-catalog.json'),
-        puppetdb_url: 'https://puppetdb.local',
+        from_fact_file: OctocatalogDiff::Spec.fixture_path('facts/facts.yaml'),
+        bootstrapped_from_dir: OctocatalogDiff::Spec.fixture_path('repos/failing-catalog'),
         node: 'tiny-catalog-2-puppetdb',
-        basedir: '/asdflkj/asdflkj/asldfjk',
         from_branch: 'foo',
-        from_env: 'foo-env'
+        from_env: 'foo-env',
+        puppet_binary: OctocatalogDiff::Spec::PUPPET_BINARY
       }
-      expect(OctocatalogDiff::PuppetDB).to receive(:new) { |*_arg| OctocatalogDiff::Mocks::PuppetDB.new }
       logger, logger_str = OctocatalogDiff::Spec.setup_logger
       testobj = OctocatalogDiff::Util::Catalogs.new(options, logger)
-      expect { testobj.send(:build_catalog_parallelizer) }.to raise_error(OctocatalogDiff::Errors::CatalogError)
-      expect(logger_str.string).to match(/Failed build_catalog for foo-env: OctocatalogDiff::Errors::FactRetrievalError/)
+      expect do
+        testobj.send(:build_catalog_parallelizer)
+      end.to raise_error(OctocatalogDiff::Errors::CatalogError)
       expect(logger_str.string).to match(/Failed build_catalog for foo-env/)
     end
   end