Add additional test coverage for util/catalogs

Author: Kevin Paulisse

spec/octocatalog-diff/tests/util/catalogs_spec.rb

@@ -290,6 +290,23 @@ def valid?
       expect(result[:from].builder.to_s).to eq('OctocatalogDiff::Catalog::PuppetDB')
       expect(result[:to].builder.to_s).to eq('OctocatalogDiff::Catalog::JSON')
     end
+
+    it 'should raise OctocatalogDiff::Errors::CatalogError if either catalog fails' do
+      options = {
+        to_catalog: OctocatalogDiff::Spec.fixture_path('catalogs/tiny-catalog.json'),
+        puppetdb_url: 'https://puppetdb.local',
+        node: 'tiny-catalog-2-puppetdb',
+        basedir: '/asdflkj/asdflkj/asldfjk',
+        from_branch: 'foo',
+        from_env: 'foo-env'
+      }
+      expect(OctocatalogDiff::PuppetDB).to receive(:new) { |*_arg| OctocatalogDiff::Mocks::PuppetDB.new }
+      logger, logger_str = OctocatalogDiff::Spec.setup_logger
+      testobj = OctocatalogDiff::Util::Catalogs.new(options, logger)
+      expect { testobj.send(:build_catalog_parallelizer) }.to raise_error(OctocatalogDiff::Errors::CatalogError)
+      expect(logger_str.string).to match(/Failed build_catalog for foo-env: OctocatalogDiff::Errors::FactRetrievalError/)
+      expect(logger_str.string).to match(/Failed build_catalog for foo-env/)
+    end
   end
 
   describe '#add_parallel_result' do