Pin brace-expansion to patched releases via overrides - #40
Merged
Conversation
The remaining high-severity brace-expansion advisories could not be resolved by 'npm audit fix' -- it converges without moving the pinned transitive copies. Adds version-scoped overrides so each major line resolves to a patched release, keeping every consumer on its expected major: brace-expansion@1 -> ^1.1.18 (was 1.1.15, via @eslint/eslintrc) brace-expansion@5 -> ^5.0.9 (was 5.0.6, via eslint) npm audit now reports 0 vulnerabilities. Lint, build and tests pass.
There was a problem hiding this comment.
Pull request overview
Pins transitive brace-expansion major lines to patched releases, resolving the remaining audit findings without incompatible upgrades.
Changes:
- Adds version-scoped npm overrides for v1 and v5.
- Regenerates the lockfile with patched versions.
Show a summary per file
| File | Description |
|---|---|
package.json |
Adds scoped security overrides. |
package-lock.json |
Locks patched transitive releases. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #39, which cleared everything
npm audit fixcould reach. One high-severitybrace-expansionfinding remained —npm audit fixconverges without moving the pinned transitive copies.Two copies were vulnerable:
@eslint/eslintrc→minimatch@31.1.151.1.18eslint→minimatch@105.0.65.0.9Adds two version-scoped overrides so each major line resolves to a patched release:
Scoping by major matters here — a blanket
"brace-expansion": "^5.0.9"would force v5 ontominimatch@3, which expects^1.1.7. This keeps every consumer on its expected major.Resolves GHSA-3jxr-9vmj-r5cp, GHSA-mh99-v99m-4gvg, GHSA-rgw5-rvv9-x895.
npm auditnow reports 0 vulnerabilities.Validation
npm run lintpasses (eslint +tsc --noEmit)npm testpasses (22 tests)npm run buildpasses