Allow browser-based MCP clients via CORS and cross-origin bypass#2359
Draft
RossTarrant wants to merge 1 commit intomainfrom
Draft
Allow browser-based MCP clients via CORS and cross-origin bypass#2359RossTarrant wants to merge 1 commit intomainfrom
RossTarrant wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add CORS support and configurable cross-origin protection to allow browser-based MCP clients to connect to the HTTP server.
Why
We recently upgraded the MCP Go SDK from v1.3.1 to v1.5.0, which brought in cross-origin request protection added in v1.4.1. This uses net/http.CrossOriginProtection to reject cross-origin POST requests by default based on the Sec-Fetch-Site header.
Browser-based clients (e.g. MCP Inspector which was used to test this PR) send Sec-Fetch-Site: cross-site and get a 403. Additionally, the HTTP server had no CORS headers, so browsers blocked requests at the preflight stage before even reaching the CSRF check.
Fixes #2342
What changed
MCP impact
Prompts tested (tool changes only)
Security / limits
No security or limits impact
Auth / permissions considered
Data exposure, filtering, or token/size limits considered
CORS uses Access-Control-Allow-Origin: * which is safe because auth is bearer-token-only (not cookie-based)
Cross-origin protection bypass is opt-in via ServerConfig; SDK default (reject) is preserved for library consumers
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs