Skip to content

Increase Smoke Claude turn budget to prevent premature engine termination#2131

Merged
lpcox merged 2 commits intomainfrom
copilot/fix-smoke-claude-issue
Apr 21, 2026
Merged

Increase Smoke Claude turn budget to prevent premature engine termination#2131
lpcox merged 2 commits intomainfrom
copilot/fix-smoke-claude-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 20, 2026

Smoke Claude was failing with an engine error even though tools and MCP connectivity were healthy. The run hit error_max_turns (num_turns: 9) before completing the workflow’s expected output path.

  • Root cause addressed

    • The workflow budget was too tight for the current prompt/tool path: engine.max-turns was 8, causing early termination under normal variance.
  • Workflow config updates

    • Updated .github/workflows/smoke-claude.md:
      • engine.max-turns: 812
    • Updated .github/workflows/smoke-claude.lock.yml to keep compiled runtime values aligned:
      • Claude CLI arg --max-turns 8--max-turns 12
      • GH_AW_MAX_TURNS: 812
      • metadata hash refreshed to match source frontmatter
  • Config alignment snippet

    # .github/workflows/smoke-claude.md
    engine:
      id: claude
      model: claude-haiku-4-5
      max-turns: 12

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/actions/github-script/git/ref/tags/v9
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq .object.sha (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.68.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.68.3 --jq .object.sha (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue Apr 20, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix smoke Claude engine failure Increase Smoke Claude turn budget to prevent premature engine termination Apr 20, 2026
Copilot AI requested a review from lpcox April 20, 2026 23:42
@lpcox lpcox marked this pull request as ready for review April 21, 2026 00:13
@lpcox lpcox requested a review from Mossaka as a code owner April 21, 2026 00:13
Copilot AI review requested due to automatic review settings April 21, 2026 00:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Increases the Smoke Claude workflow’s turn budget to avoid premature termination from hitting error_max_turns during normal prompt/tool execution variance.

Changes:

  • Updated .github/workflows/smoke-claude.md to raise engine.max-turns from 8 to 12.
  • Updated the compiled lock workflow .github/workflows/smoke-claude.lock.yml to keep runtime values aligned (--max-turns and GH_AW_MAX_TURNS set to 12) and refreshed the frontmatter hash.
Show a summary per file
File Description
.github/workflows/smoke-claude.md Raises the configured Claude engine turn budget to reduce false failures.
.github/workflows/smoke-claude.lock.yml Aligns compiled/runtime settings (CLI arg + env) and updates metadata hash accordingly.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

Test Status
GitHub MCP (list_pull_requests) ❌ 404 — MCP unavailable
GitHub.com connectivity (HTTP) ✅ 200
File write/read ⚠️ Template vars not substituted — unable to verify

Overall: FAIL — MCP connectivity failed; template variable substitution did not occur for pre-step outputs.

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

🔥 Smoke Test: Copilot BYOK (Offline) — PASS

Test Result
1. GitHub MCP (list_pull_requests)
2. GitHub.com connectivity
3. File write/read
4. BYOK inference (agent → api-proxy → api.githubcopilot.com)

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com

Overall: PASS | PR by @Copilot, assignees: @lpcox @Copilot

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results (Run: 24696048108)

  • ❌ GitHub MCP: API unavailable (HTTP 404)
  • ✅ Playwright: github.com title verified
  • ✅ File Writing: test file created
  • ✅ Bash Tool: execution successful

Overall: FAIL (1/4 tests failed)

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

PR titles:

  • Increase Smoke Claude turn budget to prevent premature engine termination
  • chore(deps): bump the all-github-actions group across 1 directory with 19 updates
  1. GitHub merged PR review ✅
  2. GH PR query (2 items) ✅
  3. Playwright GitHub title check ✅
  4. Tavily web search ❌
  5. File write/read + bash verify ✅
  6. Discussion oracle comment ✅
  7. npm ci && npm run build ✅
    Overall status: FAIL

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

PR Titles: (failed to fetch)

  • Create test file: ✅
  • Read file contents: ✅
  • Build AWF: ✅
  • GH MCP test (PR fetch): ❌

Overall: PASS (except GH MCP, which is unreachable in sandbox)

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • models.dev

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "models.dev"

See Network Configuration for more information.

🌐 Transmitted by Smoke OpenCode

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: GitHub Actions Services Connectivity ✅

Check Result
Redis PING (host.docker.internal:6379) PONG
PostgreSQL pg_isready (host.docker.internal:5432) ✅ accepting connections
PostgreSQL SELECT 1 (smoketest db, user postgres) ✅ returned 1

All checks passed. (redis-cli was unavailable, but raw RESP protocol via nc confirmed Redis responded with +PONG.)

🔌 Service connectivity validated by Smoke Services

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color passed ✅ PASS
Go env passed ✅ PASS
Go uuid passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx passed ✅ PASS
Node.js execa passed ✅ PASS
Node.js p-limit passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #2131 · ● 427.1K ·

@lpcox lpcox merged commit 92f9578 into main Apr 21, 2026
62 of 68 checks passed
@lpcox lpcox deleted the copilot/fix-smoke-claude-issue branch April 21, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Smoke Claude failed

3 participants