Add missing ecosystems to automatic GitHub Packages auth#1668
Open
JamieMagee wants to merge 1 commit intogithub:mainfrom
Open
Add missing ecosystems to automatic GitHub Packages auth#1668JamieMagee wants to merge 1 commit intogithub:mainfrom
JamieMagee wants to merge 1 commit intogithub:mainfrom
Conversation
Gradle, bun, docker_compose, and devcontainers were missing from getPackagesCredential(). Gradle and bun reuse the Maven and npm handlers respectively (same registry hosts). docker_compose and devcontainers reuse the Docker handler (ghcr.io). Includes tests for all new ecosystems.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands getPackagesCredential() to automatically add GitHub Packages credentials for additional Dependabot ecosystems that share existing registry handlers (Docker, Maven, npm).
Changes:
- Treat
docker_composeanddevcontainersas Docker ecosystems for GHCR (ghcr.io) auth. - Treat
gradleas a Maven ecosystem for GitHub Maven Packages auth. - Treat
bunas an npm ecosystem for GitHub npm Packages auth, and add tests for the new ecosystems.
Show a summary per file
| File | Description |
|---|---|
src/main.ts |
Adds switch cases so the new ecosystems reuse the existing Docker/Maven/npm credential builders. |
dist/main/index.js |
Updates the compiled bundle to include the new ecosystem cases. |
__tests__/main.test.ts |
Adds test coverage for credential creation + duplicate prevention for the new ecosystems. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/4 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle, bun, docker_compose, and devcontainers were missing from getPackagesCredential(). Gradle and bun reuse the Maven and npm handlers respectively (same registry hosts). docker_compose and devcontainers reuse the Docker handler (ghcr.io).
Includes tests for all new ecosystems.