Java: Fix false positives in evaluation-to-constant query for ErrorType

java/ql/integration-tests/java/evaluation-to-constant-errortype/ConstantExpAppearsNonConstant.qlref

@@ -0,0 +1 @@
+Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql

java/ql/integration-tests/java/evaluation-to-constant-errortype/Test.java

@@ -0,0 +1,7 @@
+class Test {
+  public static void updateFlashlights(Minecraft mc){
+    if(mc.world != null){
+
+    }
+   }
+}

java/ql/integration-tests/java/evaluation-to-constant-errortype/test.py

@@ -0,0 +1,2 @@
+def test(codeql, java):
+    codeql.database.create(build_mode="none")

java/ql/src/Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql

@@ -19,7 +19,7 @@ predicate isConstantExp(Expr e) {
   // A literal is constant.
   e instanceof Literal
   or
-  e instanceof TypeAccess
+  exists(TypeAccess ta | ta = e | not ta.getType() instanceof ErrorType)
   or
   e instanceof ArrayTypeAccess
   or