Merged
Conversation
IdrissRio
added
the
depends on internal PR
IdrissRio
force-pushed
the
idrissrio/java-maven
branch
2 times, most recently
from
29e008e to
434ec9b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds integration tests for Maven 4 compatibility, specifically testing scenarios where Maven 3 attempts to fetch Maven 4 wrapper binaries. The test ensures that CodeQL's Java analysis correctly handles this version mismatch scenario.
- Sets up a test environment with Maven 3.6.0 attempting to use Maven wrapper that references Maven 3.9.11
- Validates that Java code extraction and analysis works correctly in this configuration
- Includes test infrastructure with Python test runner and CodeQL query validation
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test.py | Python test script that downloads Maven 3.6.0 and configures environment for wrapper testing |
| methods.ql | CodeQL query to extract and validate Java methods from the test application |
| methods.expected | Expected output from the CodeQL query showing detected Java methods |
| Test.java | Simple Java test class with main method and trivial method for validation |
| pom.xml | Maven project configuration specifying Java 11 and basic compiler setup |
| mvnw.cmd | Maven wrapper script for Windows environments |
| mvnw | Maven wrapper script for Unix-like environments |
| maven-wrapper.properties | Configuration specifying Maven 3.9.11 distribution URL |
| ExtractionErrors.qlref | Reference to extraction error diagnostics query |
smowton
approved these changes
Oct 1, 2025
IdrissRio
force-pushed
the
idrissrio/java-maven
branch
from
434ec9b to
a22ec2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See internal PR