Skip to content

Shared/Cfg: Fix missing JoinBlockPredecessor. #20457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschackmull merged 2 commits into from
Sep 18, 2025
Merged

Shared/Cfg: Fix missing JoinBlockPredecessor. #20457

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5a2387
Shared/Cfg: Fix missing JoinBlockPredecessor.
aschackmull Sep 17, 2025
d93b2ed
Ruby: Accept test changes.
aschackmull Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions shared/controlflow/codeql/controlflow/Cfg.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,6 +1020,12 @@ module MakeWithSplitting<
not jbp instanceof BasicBlocks::EntryBasicBlock and
id = idOfAstNode(jbp.getFirstNode().(AstCfgNode).getAstNode()) and
kind = 1
or
exists(AnnotatedExitNode aen |
jbp.getFirstNode() = aen and
id = idOfCfgScope(aen.getScope()) and
if aen.isNormal() then kind = 2 else kind = 3
)
}

string getSplitString(BasicBlocks::JoinPredecessorBasicBlock jbp) {
Expand Down
Loading