Java: Revert wrongly generated stats file#20385
Merged
Conversation
Contributor
|
Btw, this would be easier to review if it was in two commits. |
Contributor
Author
I'll do it right away! |
IdrissRio
force-pushed
the
idrissrio/java-regression-statsfile
branch
from
9e65bab to
aa71d38
Compare
Contributor
|
Could you please rebase on latest main and do a fresh dca run, such that we don't drown out any effects of the revised stats change by the currently non-terminating base branch. |
The stats file generated in commit a6b68ec#diff-a4cfdde566085b7f1c1315487c13ef64e4869729ae7886b6c8f4267e3cd4eab6 was created using the wrong process. This commit reverts that change and manually adds the new relation for isImplicitClass.
IdrissRio
force-pushed
the
idrissrio/java-regression-statsfile
branch
from
aa71d38 to
762d2ef
Compare
aschackmull
approved these changes
Sep 11, 2025
Contributor
aschackmull
left a comment
aschackmull
left a comment
There was a problem hiding this comment.
LGTM. The combination of the two dca runs look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stats file generated in commit
a6b68ec#diff-a4cfdde566085b7f1c1315487c13ef64e4869729ae7886b6c8f4267e3cd4eab6 was created using the wrong process.
This PR reverts that change and manually adds the new relation for isImplicitClass.