C++: Fix IR construction for implicit conversions in new initializers#20306
Merged
MathiasVP merged 3 commits intogithub:mainfrom Aug 28, 2025
Merged
C++: Fix IR construction for implicit conversions in new initializers#20306MathiasVP merged 3 commits intogithub:mainfrom
new initializers#20306MathiasVP merged 3 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes IR construction for implicit conversions in new initializers by ensuring that type conversions are properly handled when constructing the intermediate representation for new expressions with initializers.
- Uses the fully converted expression instead of the raw initializer for
newexpressions - Adds test cases to verify proper IR generation for allocation with initializers requiring type conversion
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedExpr.qll | Modified to use getFullyConverted() on the initializer expression |
| cpp/ql/test/library-tests/ir/ir/ir.cpp | Added test function with new expressions requiring implicit conversions |
| cpp/ql/test/library-tests/ir/ir/raw_ir.expected | Updated expected IR output for the new test cases |
| cpp/ql/test/library-tests/ir/ir/aliased_ir.expected | Updated expected aliased IR output for the new test cases |
| cpp/ql/test/library-tests/ir/ir/PrintAST.expected | Updated expected AST output showing the implicit conversion |
Contributor
Author
|
DCA was uneventful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the title says 😂